[Bug 220888] Review Request: fakeroot - Gives a fake root environment

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: fakeroot - Gives a fake root environment


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220888


peter at thecodergeek.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |peter at thecodergeek.com




------- Additional Comments From peter at thecodergeek.com  2007-01-04 14:20 EST -------
A couple of comments (with full review coming later tonight when I get home from
work):

The gcc-c++ and /usr/bin/getopt (part of the util-linux package) BuildRequires
are not nessary, as they are part of the standard build root (see
http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions for more information).

Your BuildRoot tag is incorrect. It should be
"%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)" as specified in
the guidelines. (See
http://fedoraproject.org/wiki/Packaging/Guidelines#head-f196e7b2477c2f5dd97ef64e8eacddfb517f1aa1
for more information.)

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.