[Bug 220943] Review Request: po4a - A tool maintaining translations anywhere

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: po4a - A tool maintaining translations anywhere


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220943





------- Additional Comments From wolfy at nobugconsulting.ro  2007-01-05 00:08 EST -------
Not a very official review because I am not in fedorabugs group yet (just
requested that).

MUST items
- rpmlint on source returns only 
E: po4a unknown-key GPG#66534c2b
which can safely be ignored
- package meets naming guidelines
- package meets almost all packaging guidelines; it does not respect the
preferred buildroot, but this is not a blocker
- license is GPL, text (COPYING) is included in %doc, matches upstream
- spec file legible, in am. english 
- sha1sum 7319dcb1cbbfdff5fb5fb73cd2af92695732a36e matches upstream
- locale included via %{perl_vendorlib}/Locale/Po4a
- not relocatable
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc seems to affect runtime (could not test because package does
not build in my mock)
- no .la files
- based on spec examination, does not seem to own files or directories already
owned by other packages
- no need for .desktop file


Should
- mock build for i386/fc6&devel fails with "Cannot find build req
perl(Text::WrapI18N). Exiting."

Maybe I should add something to the repo list in mock? I have tested both fc6
and devel, with core, extras and plague-results included.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.