[Bug 214893] Review Request: sipp - SIP test tool / traffic generator

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: sipp - SIP test tool / traffic generator


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=214893





------- Additional Comments From jeff at ocjtech.us  2007-01-05 00:16 EST -------
Peter, sorry it's taken so long to do this review:

* source files match upstream
94bddbc6def599ed59c87fdd9edf5486  sipp-1.1rc8.src.tar.gz
94bddbc6def599ed59c87fdd9edf5486  sipp-1.1rc8.src.tar.gz.1
* package meets naming and packaging guidelines (except as noted below).
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
* license field matches the actual license.
* license is open source-compatible.  License text included in package.
* latest version is being packaged.
* BuildRequires are proper.
X compiler flags are not appropriate.
* %clean is present.
* package builds in mock (fc6 i386).
* package installs properly. 
* rpmlint is silent:
* %check is not present; There is no test code in the districution.
* no shared libraries are present
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers
* no unversioned .so file
* no pkconfig file
* no libtool .la droppings.

Suggestions:

* Package README.txt, MEDIA.txt, and the contents of the pcap
  directory as %doc.

Blockers:

* The code is not built using the standard compiler flags.  Modifying
  the build section to look like this will build the package with the
  proper flags:

DEBUG_FLAGS="%{optflags}" %{__make} %{?_smp_mflags} pcapplay_ossl

  The compile produces a lot of warning flags, but it completes and
  produces an executable.

  However, once I compiled sipp with the standard compiler flags the
  buffer overflow checking code is triggered when I run the following
  commands in separate windows (as a non-root user):

sipp -sn uac -i 127.0.0.1 127.0.0.1
sipp -sn uas -i 127.0.0.1

  That seems very bad to me... probably something to diecuss with the
  upstream authors.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.