[Bug 220945] Review Request: perl-Text-CharWidth - Get number of occupied columns of a string on terminal

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Text-CharWidth - Get number of occupied columns of a string on terminal


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220945





------- Additional Comments From wolfy at nobugconsulting.ro  2007-01-05 06:04 EST -------
Good:

- rpmlint on source rpm returns:
E: perl-Text-CharWidth unknown-key GPG#66534c2b
which can safely be ignored
- no output from rpmlint on the generated binary
- package meets naming guidelines
- package meets packaging guidelines, except for the %buildroot which is not the
preferred value (but non blocker)
- the original tar does not include a license file but the (packaged) README
explicitely states that the software is dual licensed as GPL and Artistic which
are both approved for inclusion in Fedora
- the License field corresponds to the above and therefore is OK
- spec file legible, in am. english
- source matches upstream, sha1sum returns
b369ce7a531539ebf5b9cf1c1b09d66846f56aa4  Text-CharWidth-0.04.tar.gz
- package compiles on devel (i386)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for separate -docs package
- nothing in %doc affects runtime
- no need for .desktop file
- no .la files

... I would approve it if I were allowed to...

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.