[Bug 221405] Review Request: libdirac - Dirac is an open source video codec

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libdirac - Dirac is an open source video codec


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221405





------- Additional Comments From rc040203 at freenet.de  2007-01-05 08:00 EST -------
- *-3 still doesn't honour RPM_OPT_FLAGS and still plays dirty games with
CFLAGS/CXXFLAGS. /me thinks you misunderstood my earlier remark.

The problem is not "make RPM_OPT_FLAGS="$RPM_OPT_FLAGS"" (Which doen't make any
sense), but the configure script mis-handling CFLAGS/CXXFLAGS and appending
compiler flags to them it MUST not add to them, such as "-O3" and "-mmmx".

- Why the dependency on valgrind?
AFAIS, this package only uses valgrind in some part of its testsuite, but not as
part of building. I.e. this dependency on valgrind only makes sense if your are
running the testsuite as part of building.

- Instead of directly using a cvs snapshot, you'd better base your package on a
released version and apply a patch if you really think shipping a bleeding edge
version is useful (I don't know, I am not familiar with libdirac's stability).

- Finally, the "autotool" correct way to generate a cvs snapshot-tarball would
be to run
cvs co && autoreconf -fi && ./configure && make dist

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.