[Bug 220944] Review Request: perl-Text-WrapI18N - Line wrapping with support for several locale setups

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Text-WrapI18N - Line wrapping with support for several locale setups


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220944


wolfy at nobugconsulting.ro changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |




------- Additional Comments From wolfy at nobugconsulting.ro  2007-01-06 06:51 EST -------
Good:

- rpmlint on source rpm returns:
E: perl-Text-WrapI18N unknown-key GPG#66534c2b
which can safely be ignored
- no output from rpmlint on the generated binary
- package meets packaging guidelines, except for the %buildroot which is not the
preferred value (but non blocker)
- the original tar does not include a license file but the (packaged) README
explicitely states that the software is dual licensed as GPL and Artistic (also
used by Perl in which the source is written) which are both approved for
inclusion in Fedora
- the License field corresponds to the above and therefore is OK
- spec file legible, in am. english
- source is latest version, matches upstream, sha1sum returns
f397756b8d0a090fdecbf9c854922c0d9825f284  Text-WrapI18N-0.06.tar.gz
- compiles in mock for devel i386; it's a noarch so no potential need for
exclusion on unsupported archs
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions are sane
- %clean ok
- macro use consistent
- code, not content
- no need for separate -docs package
- nothing in %doc affects runtime
- no need for .desktop file
- no header, static, .pc files
- no scriptlets

SHOULD
- builds in mock, creates a noarch
- the generated package can successfully be used by other programs (po4a)

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.