[Bug 221727] Review Request: cssed - CSS editor and validator

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: cssed - CSS editor and validator


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221727


mtasaka at ioa.s.u-tokyo.ac.jp changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtasaka at ioa.s.u-tokyo.ac.jp




------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2007-01-07 13:32 EST -------
Well, I have to make some comments:

* Please check the requirement for -devel package.
  cssed.pc includes the line:
-----------------------------------------------
Requires: gtk+-2.0 glib-2.0
-----------------------------------------------
  This means that -devel package needs "Requires: gtk2-devel"
  Also,
-----------------------------------------------
Cflags: -I${prefix}/share/cssed/include
-----------------------------------------------
  points to a wrong directory. Also this file 
  has a strange coding at the end (try "cat cssed.pc").

* Please avoid to use autotools when it is possible.
  It seems that from your patch against Makefile.am and
  the content of Makefile.in, you can make a patch against 
  Makefile.in, not against Makefile.am with ease.

* Please remove redundant BuildRequires. For example,
  glib2-devel is always required by gtk2-devel, so
  writting "glib2-devel"

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.