[Bug 221698] Review Request: compat-guile-16 - Guile 1.6 compatibility package

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: compat-guile-16 - Guile 1.6 compatibility package


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221698


mtasaka at ioa.s.u-tokyo.ac.jp changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Review Request: compat-guile|Review Request: compat-
                   |- Guile 1.6 compatibility   |guile-16 - Guile 1.6
                   |package                     |compatibility package
OtherBugsDependingO|163778                      |163779
              nThis|                            |




------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2007-01-08 12:02 EST -------
= Well, from my eye inspection, i.e.
-------------------------------------------------
( for f in `rpm -ql compat-guile-16-devel compat-guile-16 | sort` ; do if file
$f | grep -q text ; then echo $f ; fi ; done ) | xargs grep guile16
-------------------------------------------------
  all "guile16" words included in
  the texts in compat-guile-16(-devel) are correctly changed
  to guile16 (if needed).

Then:

**
-------------------------------------------------
- Added automake in BR
-------------------------------------------------
  Well, I didn't mean by that. What I meant is -devel package should have
-------------------------------------------------
Requires: %{name} = %{version}-%{release}, automake
-------------------------------------------------
  because -devel package includes %{_datadir}/aclocal/guile16.m4.
  Actually automake is not needed for BuildRequires as you don't call
  automake in build process.

** Source0:
   must be: ftp://ftp.gnu.org/gnu/guile/guile-1.6.7.tar.gz
   (md5sum coincides)

** %{buildroot} vs $RPM_BUILD_ROOT
   Please choose one.

Please fix the issues marked as **.
Other things are okay.
--------------------------------------------------------
  This package (compat-guile-16) is APPROVED by me.
--------------------------------------------------------

  Note:
  It seems that the newest guile of 1.6 series is 1.6.8 .
  Please check 1.6.8 after you first import 1.6.7 into Fedora Extras.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.