[Bug 222043] Review Request: gnomescan - Gnome Scanner Utility

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gnomescan - Gnome Scanner Utility


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222043


maxx at krakoa.dk changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Review Request: gnomescan - |Review Request: gnomescan -
                   |Gnome Scanner Utility       |Gnome Scanner Utility
                 CC|                            |maxx at krakoa.dk




------- Additional Comments From maxx at krakoa.dk  2007-01-09 17:33 EST -------
I am not an official reviewer, so consider this a pre-review.

Builds in mock on i386 fedora core 6. Installs and runs - however I haven't got
a scanner, so I cannot test functionality.

rpmlint produces one error:
W: gnomescan-devel no-documentation

Which I suppose is fine, since the documentation belongs in the main package and
not in the devel package.

Package and spec file are correctly named
Language and license are fine.
find_lang is correctly used for locales.
ldconfig is correctly called in %post and %postun
Packages correctly own directories.
Correctly handles pkgconfig files.
Header files are in devel package.
Includes a .desktop file that is correctly installed.

What I am unsure about is this. It seems to me that this includes both gnomescan
(flegita - the actual scanning application) and libgnomescan. Should the two be
packaged separately?


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.