[Bug 222043] Review Request: gnomescan - Gnome Scanner Utility

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gnomescan - Gnome Scanner Utility


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222043





------- Additional Comments From dakingun at gmail.com  2007-01-10 09:08 EST -------
(In reply to comment #3)

> 
> However, I found that you don't need pkgconfig as BR for main package.
Maybe not explicitly (probably some other dependencies pulled it in inside mock
for you), if you check the configure log you'll see that it checks for the
presence of pkgconfig, so its needed  for building.

> Also, do we really need libtool as BR and all other make LIBTOOL? I removed them
> and did mock test and it went fine.
Did you run rpmlint on the resulting binary? If you did, you will have found out
it has some rpath issues caused by using the libtool script bundled with the
package. That's the reason for the libtool as BR and all other make LIBTOOL.
(See
http://fedoraproject.org/wiki/Extras/Schedule/RpathCheckBuildsys?highlight=%28rpath%29)

As for your other comment on separate package for gimp-plugin, I don't think its
necessary just for a single file. Or is there some technical reason(s) for it to
be a separate package?

> Can you check that with testing application??
>  



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.