[Bug 219869] Review Request: perl-Mozilla-LDAP

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Mozilla-LDAP
Alias: perldap

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=219869





------- Additional Comments From dennis at ausil.us  2007-01-10 17:32 EST -------
Two small issues 
include  MPL-1.1.txt RELEASE  in %doc  and change the license field to MPL  as 
thats what it seems to be licensed under.

 package meets naming and packaging guidelines.
 specfile is properly named, is cleanly written and uses macros consistently.
 dist tag is present.
 build root is correct.
      %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
 license is open source-compatible.   MPL License text included in package.
 source files match upstream:
    136f74d7649ada77cdf7657bb01a165f  perl-mozldap-1.5.tar.gz
    136f74d7649ada77cdf7657bb01a165f  ../SOURCES/perl-mozldap-1.5.tar.gz
 latest version is being packaged.
 BuildRequires are proper.
 package builds in mock ( on FC-6 ).
 rpmlint is silent.
 final provides and requires are sane:
 no shared libraries are present.
 package is not relocatable.
 owns the directories it creates.
 doesn't own any directories it shouldn't.
 no duplicates in %files.
 file permissions are appropriate.
 %clean is present.

 no scriptlets present.
 code, not content.
 documentation is small, so no -docs subpackage is necessary.
 %docs are not necessary for the proper functioning of the package.
 no headers.
 no pkgconfig files.
 no libtool .la droppings.
 not a GUI app.
 not a web app.

APPROVED using the attached spec file which fixes the issues 

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.