[Bug 221027] Review Request: LabPlot - Data Analysis and Visualization

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: LabPlot - Data Analysis and Visualization


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221027


rdieter at math.unl.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rdieter at math.unl.edu




------- Additional Comments From rdieter at math.unl.edu  2007-01-11 08:35 EST -------
A few comments:
1. 
Requires:          kdelibs ImageMagick-c++ gsl fftw
aren't required, rpm will(should!) pick these up automatically, you should
remove these manual dependencies.

2. subpkgs, particularly -devel, should
Requires: %{name} = %{version}-%{devel}

3.  configure \
%ifarch x86_64 sparc64 ppc64 amd64
  --enable-libsuffix=64 \
  --with-qt-libraries=$QTDIR/lib \
%endif
shouldn't be required.  qt packaging properly sets QTLIB env variable for awhile
now.

4.  instead of 
sed -i -e \
    s'|Categories=Qt;KDE;Education;Science;Physics;Math;|Categories=Science;|' \
    %{buildroot}%{_datadir}/applications/kde/%{name}.desktop
It's preferable to use
desktop-file-install --remove-category="..."
(and I'd argue you shouldn't be removing "Qt;KDE;Education" categories

5.  items under
%{_datadir}/apps/%{name}/handbook
imo, should be marked %doc

6.  These are not required:
%post devel -p /sbin/ldconfig
%postun devel -p /sbin/ldconfig
and -devel's
Requires(post):    /sbin/ldconfig
Requires(postun):  /sbin/ldconfig


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.