[Bug 222326] Review Request: gxine - GTK frontend for the xine multimedia library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gxine - GTK frontend for the xine multimedia library


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222326





------- Additional Comments From josef at toxicpanda.com  2007-01-11 14:25 EST -------
==== REVIEW CHECKLIST ====
- rpmlint output is clean
- package meets package naming guidelines
- spec filename matches %{name}
- package meets packaging guidelines
- package licensed with open source compatible license
- license matches actual license
- license file included in %doc
- spec written in American english
- spec file is legible
- sources match upstream (tho as a side note the URL didn't work)
0df37a7a38ea0d63129d2590971caabb  /home/josef/gxine-0.5.10.tar.bz2
- package successfully compiles and builds on x86_64 FC6
- all build dependencies listed in BR
- locales handled properly
- no shared libraries
- package is not relocatable
- package owns all directories it creates
- directories it does not create owned by default packages
- no duplicates in %files
- file permissions set properly
- contains proper %clean section
- macro usage consistent
- package contains code
- no large documentation
- files in %doc do not affect runtime
- no header files or static libraries
- no pkgconfig files
- no library files with suffix
- no need for devel subpackage
- no .la files
* desktop file is not installed via the appropriate methods
- package does not own files or directories owned by other packages

====Things that need to be fixed====
* I found the upstream sources, but the URL that was in your spec file did not 
resolve, you may want to find a more permament URL.
* You need to install the desktop file appropriatly, look here for an example
http://fedoraproject.org/wiki/Packaging/Guidelines#head-254ddf07aae20a23ced8cecc219d8f73926e9755
  gxine seems to install it by itself, so you will want to do something like 
what I did for geany
	http://www.toxicpanda.com/geany.spec
* for gxine-mozplugin, it would not install because you have

  Requires: %{name}=%{version}-%{release}

  you need to put a space in between the '=', so it looks like this

  Requires: %{name} = %{version}-%{release}

  and then it will work.


I am not sponsored, this is just a review to help me get sponsored.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.