[Bug 219873] Review Request: kio_sword - lightweight Sword front-end for KDE

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: kio_sword - lightweight Sword front-end for KDE


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=219873


dakingun at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |dakingun at gmail.com
OtherBugsDependingO|163776                      |163778
              nThis|                            |




------- Additional Comments From dakingun at gmail.com  2007-01-12 10:49 EST -------
Hi David,
A couple of needswork and nitpicks,

NEEDSWORK:
* Packages doesn't build in x86_64 mock
* Needs to call ldconfig in post and postun
* Ought to use the %find_lang for locales/translations
* Packages must NOT contain any .la libtool archives

NITS:
* You should really require sword >=1.5.8
* Setting the CFLAGS in the spec is not necessary, it's already set by rpmbuild
* Also setting the $PATH for QT is not necesaary, already done /etc/profile.d/qt.sh
(I notice you only set this variables, you didn't export them)
* I'm not sure what '--preserve-root' option does when you clean the buildroot,
but I think its unnecesary.
* I'm not 

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.