[Bug 222087] Review Request: pcmanx-gtk2 - Telnet client designed for BBS browsing

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: pcmanx-gtk2 - Telnet client designed for BBS browsing


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222087





------- Additional Comments From sdl.web at gmail.com  2007-01-12 14:45 EST -------
(In reply to comment #3)
> Well, several issues from very quick check.
> (0.3.5-2)
> 
> * Your own desktop misses Icon item. Why not use original
>   desktop file included in tarball?
>   Note: for original desktop, the Icon description is enough
>   with
> -----------------------------------------
> Icon=pcmanx.png
> -----------------------------------------

The original .desktop contains two Icon entries.

No it's not missing. See line: Icon=pcmanx
Should I change it to pcmanx.png?

> 
> * Still fails on mockbuild
Where can I use this? or do I have to setup my own?

> ------------------------------------------
> + /usr/lib/rpm/redhat/find-lang.sh
> /var/tmp/pcmanx-gtk2-0.3.5-2.fc7-root-mockbuild pcmanx
> No translations found for pcmanx in
/var/tmp/pcmanx-gtk2-0.3.5-2.fc7-root-mockbuild
> error: Bad exit status from /var/tmp/rpm-tmp.40758 (%install)
> ------------------------------------------

Any ideas why it failed? AFAIK, there are thse files:

/usr/share/locale/zh_CN/LC_MESSAGES/pcmanx.mo
/usr/share/locale/zh_TW/LC_MESSAGES/pcmanx.mo


> 
> * Debuginfo rpm issue
> ----------------------------------------------
>   make install-strip DESTDIR=$RPM_BUILD_ROOT
> -----------------------------------------------
>   Well, don't strip binaries. Debuginfo rpm becomes useless.
> 
> * Timestamps
>   Please keep timestamps for installed text files. Usually
> --------------------------------------------------
>    make install INSTALL="install -c -p"
> ---------------------------------------------------
>   works.
> 
> * Desktop category
>   Original desktop file includes
> ---------------------------------------------------
>   Application
> ----------------------------------------------------
>   category. This is deprecated and this should be removed.

Removed from desktop file.

> ----------------------------------------------------
> --add-category X-Fedora
> --add-category X-Red-Hat-Extra
> --add-category Applications
> ----------------------------------------------------
>   All these are not deprecated and should be removed

I can't understand this. Should be removed or not?

I keep them for now.

> ----------------------------------------------------
> --add-category Internet
> ----------------------------------------------------
>   This is forbidden. Perhaps you meant "Network"?

fixed.
 
> * scriptlets
> ----------------------------------------------------
> update-desktop-database > /dev/null 2>&1 || :
> ----------------------------------------------------
>   This is not needed because pcmanx desktop does not contain
>   mime types description.

fixed.

> 
> * file entry
> -------------------------------------
> %{_libdir}/*
> --------------------------------------
>    This is wrong because this includes %{_libdir}/debug,
>    which should appear only in debuginfo rpm.
fixed.

The new src.rpm is here:
http://www.srcf.ucam.org/~sl392/fedora/SRPMs/pcmanx-gtk2-0.3.5-3.leof6.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.