[Bug 222456] Review Request: bibletime - BibleTime is a frontend for the SWORD Bible Framework

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: bibletime - BibleTime is a frontend for the  SWORD Bible Framework


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222456


dakingun at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |dakingun at gmail.com
OtherBugsDependingO|163776                      |163778
              nThis|                            |




------- Additional Comments From dakingun at gmail.com  2007-01-12 23:30 EST -------
Hi David,
A couple of needswork,

NEEDSWORK:
* Buildrequire is needed for gettext (though it builds without it)
* rpmlint complaints (on the binary)
  W: bibletime dangling-relative-symlink                                       
                                                                       
/usr/share/doc/HTML/en/bibletime/handbook/common ../../common
  W: bibletime devel-file-in-non-devel-package /usr/include/bibletimeinterface.h
  W: bibletime dangling-relative-symlink
/usr/share/doc/HTML/en/bibletime/howto/common ../../common
 The 1st and the 3rd warnings are being fixed upstream, we can wait on them for
those, the second one I believe can be ignored
 There is also a load of warnings on the desktop file installation, the attached
 patch fixes it. However to use the patch, you need to remove the add-category
and remove-key options from desktop-file-install call in the spec file. The
add-category X-Fedora had been judged to be unnecesary and the rest are taking
care of in the patch.

Other issues (in the spec):
* make bibletime.desktop is not necessary (doesn't do anything)in the build
section, the desktop file was created by configure already; that line can be removed
* I think you can also remove those preserve-root options ;)
* Calling /sbin/ldconfig in post and postun is not necessary, since bibletime
doesn't ship any library
* There is no need for the 2 lines after make install, the --dir option in the
desktop-file-install takes care of that. (By the way, i don't think it ought to
be hidden under kde subdir in %{_datadir}/applications/, bibletime can be useful
for folks who generally prefer other DE too). 
* You listed %{_datadir}/apps/bibletime/bibletimeui.rc and
%{_datadir}/apps/bibletime/tips twice, you can chmod them to 0644 in the install
section, and remove their explicit listing from the files section.
* I think its also a nice idea to use the %find_lang macro for the documentation
files as done for kio_sword.

I'm attaching a patch (to the spec) that implement fix these issues, use it as
you like.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.