[Bug 199682] Review Request: dbi-link - Partial implementation of the SQL/MED portion of the SQL:2003 specification

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: dbi-link - Partial implementation of the SQL/MED portion of the SQL:2003 specification


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199682





------- Additional Comments From kevin at tummy.com  2007-01-13 00:01 EST -------
OK - Package meets naming and packaging guidelines
OK - Spec file matches base package name.
OK - Spec has consistant macro usage.
OK - Meets Packaging Guidelines.
See below - License
See below- License field in spec matches
See below- License file included in package
OK - Spec in American English
OK - Spec is legible.
See below - Sources match upstream md5sum:
OK - Package has %defattr and permissions on files is good.
OK - Package has a correct %clean section.
OK - Package has correct buildroot
OK - Package is code or permissible content.
OK - Packages %doc files don't affect runtime.

OK - Package compiles and builds on at least one arch.
OK - Package has no duplicate files in %files.
OK - Package doesn't own any directories other packages own.
See below - Package owns all the directories it creates.
See below - No rpmlint output.
OK - final provides and requires are sane:

SHOULD Items:

OK - Should build in mock.
OK (i386/x86_64) - Should build on all supported archs
See below - Should have subpackages require base package with fully versioned 
depend.
See below - Should have dist tag
OK - Should package latest version

Issues:

1. Not a blocker, but you should consider very strongly using
the %{?dist} tag.

2. You have the license as GPL in the spec, but the pgfoundry
page says "BSD". The included copyright.txt file appears to be the
orig BSD license with advertising clause.

3. Suggest you provide a full download url for the Source0 line.
In fact, now I can't find a download link for the 1.0.0 release.
Only the new 2.0beta1 seems to be available. Perhaps thats the
prefered version to package now?

4. This package should own:
%{_datadir}/pgsql/%{name}
directory.

5. rpmlint says:

W: dbi-link no-%build-section

You could add a empty %build to fix this. I seem to remember some
other problems with specs with no %build section, so you should
probibly add it anyhow. Shouldn't hurt.

6. Should change the Requires for the dbi-link-test subpackage from:
Requires:       %{name}
to
Requires:       %{name} = %{version}-%{release}


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.