[Bug 221670] Review Request: php-pear-Net-UserAgent-Detect - Extract information from an HTTP user agent

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-Net-UserAgent-Detect - Extract information from an HTTP user agent
Alias: Net-UserAgent-Detect

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221670


kevin at tummy.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |kevin at tummy.com
OtherBugsDependingO|163776                      |163778
              nThis|                            |




------- Additional Comments From kevin at tummy.com  2007-01-13 00:55 EST -------
OK - Spec has consistant macro usage.
OK - Meets Packaging Guidelines.
OK - License (PHP)
OK - License field in spec matches
See below - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
87217ac170577bc02cbb99094d1a9a80  Net_UserAgent_Detect-2.2.0.tgz
87217ac170577bc02cbb99094d1a9a80  Net_UserAgent_Detect-2.2.0.tgz.1
c949c65eebc8d2444abe64dd6c6be438f6e218a8  Net_UserAgent_Detect-2.2.0.tgz
c949c65eebc8d2444abe64dd6c6be438f6e218a8  Net_UserAgent_Detect-2.2.0.tgz.1
OK - BuildRequires correct
OK - Package has %defattr and permissions on files is good.
OK - Package has a correct %clean section.
OK - Package has correct buildroot
OK - Package is code or permissible content.
OK - Packages %doc files don't affect runtime.

OK - Package compiles and builds on at least one arch.
OK - Package has no duplicate files in %files.
See below - Package doesn't own any directories other packages own.
OK - Package owns all the directories it creates.
OK - No rpmlint output.
OK - final provides and requires are sane:

SHOULD Items:

OK - Should build in mock.
OK(i386/x86_64) - Should build on all supported archs
OK - Should have dist tag
OK - Should package latest version

Issues:

1. According to the comments in the source file the license of
this package is the php 2.0 license, available as:
http://www.php.net/license/2_02.txt
The PHP-LICENSE-3.01 included seems to be a newer, diffrent version.

2. This package owns the
/usr/share/pear/Net directory. Should it? Or should it require some
other package that does?


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.