[Bug 222456] Review Request: bibletime - BibleTime is a frontend for the SWORD Bible Framework

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: bibletime - BibleTime is a frontend for the  SWORD Bible Framework


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222456


dakingun at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |




------- Additional Comments From dakingun at gmail.com  2007-01-13 12:25 EST -------
(In reply to comment #4)

> With the find_lang... I think again this is probably a no-op, as I believe 
> that the i18n stuff is in a separate tarball and not in the main BT 
> distribution. 
Now thinking about it again, I believe you're right. Considering that the review
guildelines says locale files must not be explicitly listed, and since it
doesn't hurt, I think it can stay.
 
> Almost there - I hope!
Yes.

GOOD:
* rmplint silent on mock srpm
* rpmlint warning on mock built binary can be ignored (targets really exist);
(W: bibletime dangling-relative-symlink
/usr/share/doc/HTML/en/bibletime/handbook/common ../../common
W: bibletime devel-file-in-non-devel-package /usr/include/bibletimeinterface.h
- A separate -devel subpackage is not needed for this, I believe. Moreso BT
doesn't ship any library 
W: bibletime dangling-relative-symlink)
/usr/share/doc/HTML/en/bibletime/howto/common ../../common
* source tarball matches upstream's
md5sum: b2b8b624d21d397201aec742d43501e5  bibletime-1.6.2.tar.bz2
* package name meets the Package Naming Guidelines.
* Satifies the Packaging Guidelines.
* Builds in mock (x86_64 development)
* Installs and works OK (for me at least)
* License: GPL
* Spec file generally OK.

APPROVED.

It'll be nice to include the 'Changelog' with the README and License in the %doc
section before/after you eventually import it into CVS.
Also please don't forget the bibletime-i18n you promised. 

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.