[Bug 221665] Review Request: php-pear-Numbers-Roman - Provides methods for converting to and from Roman Numerals

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-Numbers-Roman - Provides methods for converting to and from Roman Numerals
Alias: pear-Numbers-Roman

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221665


fedora at theholbrooks.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163776                      |163779
              nThis|                            |




------- Additional Comments From fedora at theholbrooks.org  2007-01-13 23:55 EST -------
REVIEW:
=======
OK - package meets naming and packaging guidelines.
OK - specfile is properly named, is cleanly written and uses macros consistently.
OK - dist tag is present.
OK - build root is correct.
OK - license field matches the actual license.
OK - license is open source-compatible.
ok - source files match upstream:
5103711a2e29d48a5ccda8ba1a11c893  Numbers_Roman-1.0.1.tgz
5103711a2e29d48a5ccda8ba1a11c893  Numbers_Roman-1.0.1.tgz
OK - latest version is being packaged.
OK - BuildRequires are proper.
OK - package builds in mock
OK - rpmlint is silent.
OK - final provides and requires are sane:
OK - no shared libraries are present.
OK - package is not relocatable.
OK - owns the directories it creates.
OK - doesn't own any directories it shouldn't.
OK - no duplicates in %files.
OK - file permissions are appropriate.
OK - %clean is present.
OK - %check is not present, no tests included by upstream
OK - pear scriptlets are standard
OK - code, not content.
OK - documentation is small, so no -docs subpackage is necessary.
OK - no headers.
OK - no pkgconfig files.
OK - no libtool .la droppings.
OK - not a GUI app.

Cut-and-dry pear package.  APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.