[Bug 167147] Review Request: Aqsis - 3D Rendering system

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Aqsis - 3D Rendering system


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=167147





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2007-01-17 11:17 EST -------
Well, much improvement for this package!!

A. Packaging issue (mainly in
   http://fedoraproject.org/wiki/Packaging/Guidelines )

So, first full review.
(Again note: please increase the release number 
 when you change the spec file, and reset the release
 number when you use new source).

* Requires:
-------------------------------------------------------
Requires: fltk >= 1.1.0, libjpeg >= 6b, libtiff >= 3.7.1, OpenEXR
-------------------------------------------------------
  These should not be needed. Libraries' dependencies automatically
  checked by rpmbuild correctly pull these dependencies.

* Documentation
  - "INSTALL" should not be necessary. This is needed for
    people who want to rebuild this package by themselves.

* ChangeLog
  - 1.2.0-0.6alpha2
    should be 1.2.0-0.6.alpha2

* Compilation flags
  - Well, please look at the build log.
    This spec file:
    1. Once compile at %build stage using scons. At this time
       compiler uses Fedora specific compilation flags.
    2. Next at %install stage, scons tries to compile all targets
       once more!! At this stage, compiler does not use Fedora
       specific compilation flags, so this is wrong.

    ? Doesn't scons accept the argument like --skip-build at
      install stage like usual "setup.py" written in python?
    ? Or are there any way to avoid twice compilation?
    - If not, move all compilation using scons to %install stage,
      compiling twice is redundant.

* Encodings:
  - Please change the encoding of the following file(s)
    to UTF-8.
-----------------------------------------------------
    /usr/share/doc/aqsis-1.2.0/AUTHORS:         ISO-8859 English text
-----------------------------------------------------

  = (not a blocker) If you are upstream, please change all
     text files to UTF-8 for next tarball.

= License (okay)
  = Some files are licensed not under LGPL or GPL.
    ./displays/d_sdcBMP/d_sdcBMP.cpp
    ./displays/d_sdcWin32/d_sdcWin32.cpp
    ./shadercompiler/slpp/pp*
    ./displays/d_exr/dspyhlpr.c
    ./displays/d_sdcWin32/interface.c
    ./displays/d_sdcWin32/d_sdcWin32.h
    = None of them conflicts with GPL.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.