[Bug 222521] Review Request: IceWM - Lightweight Window Manager.

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: IceWM -  Lightweight Window Manager.


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222521





------- Additional Comments From pertusus at free.fr  2007-01-17 15:32 EST -------
(In reply to comment #19)

> * ICE_CXX_FLAG_ACCEPT:
> OK. I understand. (Admittedly I'm not that experienced with automake/autoconf -
> so bear with me.)
> Does the default flag set poses any problem?
> I'm reluctant to mock around with the default flags - I've been bitten by GCC
> too many times to take this matter lightly.

I think that it would be right if you added a comment in the 
specfile to state something along that

# the following compile flags are set in configure:
# -fpermissive -Wall -Wpointer-arith -Wconversion -Wwrite-strings 
# -Winline -Woverloaded-virtual -W -fno-exceptions -fno-rtti

Then you could have a look at gcc man page to verify that nothing
potentially wrong is done.


> Ay... I CC'ed myself. Once it changes I'll replace the gnome-menu with
redhat-menus.

In fact I am not sure that any of these dependency is usefull. They 
will certainly be used if present. It is right in the current spec
file as these deps are not there.

> * Default configuration. (/etc/icewm):
> OK, I'll return them to their original position. Never the less, I'll be wise to
> sym-link /etc/icewm/xxx to /usr/share/icewm/xxx as it's the logical place for
> system-wide configuration files.

Certainly not. /usr/share/icewm/xxx is for defaults from the vendor (ie you)
while /etc/icewm/xxx is for system-wide configuration files.

> * GNOME/KDE:
> As I'm using the freedesktop files (/share/desktop-directories/), both menus
> should be identical, no?

I guess so. 

> * icewm-xdg-menu, wm-session:
> Thanks. Integrated.
> It's a bit (?) slow. I'm thinking about using gnome-menu with a static list of
> directories (E.g. Utilities, Office, Development, Games, Internet, Multimedia)

That could be right. But gnome-menu2 isn't only broken because it adds
empty submenus, it also miss some apps. For example I couldn't find
gnochm nor kchmviewer (I maintain them, that's why I 'test' menus and
mime opening apps on them).

What about asking upstream for a possibility to have something like 
menuprog, but which is called only when starting icewm?

> - Gilboa
It is not wrong to add your name in bugzilla tickets, but it is 
not strictly necessary, since it is already at the top of the tickets 
(with your mail address for logged in people). Sorry if you already
know it and do it on purpose...

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.