[Bug 222648] Review Request: audacious-plugin-fc - Future Composer plugin for Audacious

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: audacious-plugin-fc - Future Composer plugin for Audacious


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222648





------- Additional Comments From martin.sourada at seznam.cz  2007-01-17 16:57 EST -------
====REVIEW CHECKLIST====
* rpmlint not silent:
  E: audacious-plugin-fc no-changelogname-tag
  E: audacious-plugin-fc unknown-key GPG#b8af1c54
- package naming guidelines met
- spec file name matches %%{name}
* packaging guidelines not met:
  - missing %%changelog entries in spec file
  - (slightly different build root from the preferred one)
- Package licensed with GPL compatible license
- %%doc section OK
- spec written in American English
- spec file legible (only you should remove in the %%install section "mkdir -p
$RPM_BUILD_ROOT" - it's not necessary; and as mentioned above, %%changelog missing)
- source match upstream (613c456b525d0f5ebce912a981e57264 
audacious-plugin-fc-0.1.tar.bz2)
- builds successfully on at least i386 FC6
- all build dependences listed
- locales handled properly (none present)
- no shared libraries
- package is not relocatable
- package owns all its directories
- dirs not owned is owned by required package(s)
- no duplicates
- file permissions set properly
- contains proper %%clean section
- macros used consistently
- package contains code
- no large docs
- no -devel subpackage
- no pkgconfig files
- no libraries with suffix, no static libraries
- not a GUI app
- package does not own dirs or files owned by other packages
- builds in mock

====Things need to be done====
Add %%changelog section to your specfile:
http://fedoraproject.org/wiki/Packaging/Guidelines#head-b7d622f4bb245300199c6a33128acce5fb453213

You should change build root to the prefered one:
http://fedoraproject.org/wiki/Packaging/Guidelines#head-f196e7b2477c2f5dd97ef64e8eacddfb517f1aa1

As mentioned above, you should remove from the %%install section "mkdir -p
$RPM_BUILD_ROOT". It is not necessary.


I am not sponsored. This pre-review is to help me get sponsored.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.