[Bug 222594] Review Request: seedit: SELinux Policy Editor

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: seedit: SELinux Policy Editor


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222594





------- Additional Comments From lxtnow at gmail.com  2007-01-17 23:24 EST -------
hi,

- for fisrt:
i checked out your spec file and...it doesn't meets with extras Packaging
Guidelines.
see http://fedoraproject.org/wiki/Packaging/Guidelines

Theres are a lot of things to review in your SPEC file,
a lot of things must be fix.

%{distro} can be remove, %{?dist} do the same thing.

#policy,gui subpackages are build only when arch is "noarch" --> why don't you
set them to noarch in spec file ?

your source0 must be point to the full path to verify the tarball.

you use cd and cd .. to enter and exit from an subfolder, you can use
pushd to enter and popd to exit.

your desktop-file-install command miss some option such as mode and -add-categories.

there is a lot of macros which's not in the right place.






-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.