[Bug 223039] Review Request: libgimme-codec - Helper library for automated codecs installation

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libgimme-codec - Helper library for automated codecs installation


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=223039


mclasen at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
OtherBugsDependingO|188267                      |188268
              nThis|                            |




------- Additional Comments From mclasen at redhat.com  2007-01-19 21:57 EST -------
Starting a formal review based on the modified spec:

+ rpmlint only warns about missing docs, which is fine
+ package is named according to the naming guidelines
+ spec name equal package name
+ spec follows packaging guidelines
+ license is LGPL
+ license tag matches actual license
+ tarball doesn't include license file
+ spec file is in English
+ spec file is legible
+ md5sums of upstream source matches
+ package built fine in mock
+ BuildRequires are complete
+ no locale data
+ ldconfig called in %post and %postun
+ package not relocatable
+ package owns all created directories
+ file lists contain no dupes
+ files have proper permissions, all file lists have %defattr
+ %clean is there
+ macros are used consistently
+ package contains code
+ headers are in -devel
+ -devel requires base
+ no .pc files 
+ no .la files
+ no desktop files
+ package does not own standard directories

Accepted

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.