[Bug 221405] Review Request: libdirac - Dirac is an open source video codec

bugzilla at redhat.com bugzilla at redhat.com
Sat Jan 20 22:23:22 UTC 2007


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libdirac - Dirac is an open source video codec


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221405


rpm at greysector.net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED




------- Additional Comments From rpm at greysector.net  2007-01-20 17:23 EST -------
Per
http://fedoraproject.org/wiki/Packaging/NamingGuidelines#head-cfd71146dbb6f00cec9fe3623ea619f843394837
the release field should be:
Release:        5.%{cvs}cvs%{?dist}

Why is the testsuite disabled?

I don't like /usr/bin/ binaries in a package called libwhatever. Moreover, if
the source tarball is called dirac, why is the main package called libdirac?
Please put the binaries in a package named dirac

There are two redundant BuildRequires: libtool requires automake and automake
requires autoconf.

Builds fine in mock/x86_64/devel.

Shouldn't package docs be in %{_datadir}/doc/dirac-docs-%{version} ?

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the Fedora-package-review mailing list