[Bug 223657] Review Request: PerceptualDiff - An image comparison utility

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: PerceptualDiff - An image comparison utility


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=223657





------- Additional Comments From rc040203 at freenet.de  2007-01-21 08:07 EST -------
Tobi, please make yourself familiar with the Fedora Packaging GuideLines.


MUSTFIX:

- Check your BuildRequires.
  ATM, building fails right from the beginning:
...
+ cmake -DCMAKE_INSTALL_PREFIX:PATH=/usr .
/var/tmp/rpm-tmp.39497: line 27: cmake: command not found
error: Bad exit status from /var/tmp/rpm-tmp.39497 (%build)

=> BuildRequires: cmake

- Don't use strip in %install
Remove the "strip"-line

- Broken source code, triggering warning during the build
  ... warning: no newline at end of file

- Build also fails on i386:
  ...
Linking CXX executable perceptualdiff
CMakeFiles/perceptualdiff.dir/RGBAImage.o: In function `RGBAImage::ReadPNG(char*)':
RGBAImage.cpp:(.text+0x527): undefined reference to `png_read_destroy'
collect2: ld returned 1 exit status
make[2]: *** [perceptualdiff] Error 1
make[1]: *** [CMakeFiles/perceptualdiff.dir/all] Error 2


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.