[Bug 223592] Review Request: wuja - Gnome desktop applet for integration with Google calendar

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: wuja - Gnome desktop applet for integration with Google calendar


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=223592





------- Additional Comments From fedora at christoph-wickert.de  2007-01-21 10:48 EST -------
Some initial comments:

1. You should consider renaming this package to something like gnome-wuja,
gnome-applet-wuja or gnome-wuja-applet. See the 'Addon Packages' section of the
Naming guidelines for more info.
http://fedoraproject.org/wiki/Packaging/NamingGuidelines#head-e865dfbf5ffb4156a1bdf299ace96f48af903a7a
If you rename this pacakge you should also a a Poovides: with the original name
to make 'yum install wuja' work. This would be similar to 
http://fedoraproject.org/wiki/PackagingDrafts/ProvidesObsoletes

2. change 
    /etc/gconf/schemas/wuja.schema to 
    %{_sysconfdir}/gconf/schemas/wuja.schema and
    /usr/bin/wuja to 
    %{_bindir}/wuja

absolute paths are a No-Go. See http://fedoraproject.org/wiki/Extras/RPMMacros
for a list of valid macros.

3. wuja.schema is not installed properly in gconf. You need to disable/skip
schemas install in setup.py and do this in %post, %pre and %preun. See 
http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#head-6c2101d8f810cc95c677c8c27f43573b0bc23cb1

4. You should think about stripping down the files section with wildcards, e. g.
    %{python_sitelib}/wuja/calendar.py*
    %{python_sitelib}/wuja/data/*.png
    %{python_sitelib}/wuja/data/*.glade

You could even use a minimal definition like
    %doc AUTHORS LICENSE README
    %{_sysconfdir}/gconf/schemas/wuja.schema
    %{_bindir}/wuja
    %{python_sitelib}/wuja/

Makes sense as long as you are not planning to separate parts of the package or
exclude certain files.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.