[Bug 223601] Review Request: perl-B-Keywords - Lists of reserved barewords and symbol names
bugzilla at redhat.com
bugzilla at redhat.com
Mon Jan 22 05:57:37 UTC 2007
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: perl-B-Keywords - Lists of reserved barewords and symbol names
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=223601
panemade at gmail.com changed:
What |Removed |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778 |163779
nThis| |
------- Additional Comments From panemade at gmail.com 2007-01-22 00:57 EST -------
Review:
+ package builds in mock (development i386).
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream.
f8b40e7dc864fc27fc69638e58cc651c B-Keywords-1.05.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Dose owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test
PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0,
'blib/lib', 'blib/arch')" t/*.t
t/01pod.............ok
t/02pod-coverage....ok
t/03yaml............ok
t/04boilerplate.....ok
t/10basic...........ok
t/11keywords........ok
All tests successful.
Files=6, Tests=14, 0 wallclock secs ( 0.30 cusr + 0.05 csys = 0.35 CPU)
-APPROVED.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
More information about the Fedora-package-review
mailing list