[Bug 222365] Review Request: eclipse-changelog - simplifies the task of maintaining ChangeLogs for projects

bugzilla at redhat.com bugzilla at redhat.com
Mon Jan 22 16:43:23 UTC 2007


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: eclipse-changelog - simplifies the task of maintaining ChangeLogs for projects


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222365





------- Additional Comments From overholt at redhat.com  2007-01-22 11:43 EST -------
(In reply to comment #21)
> (In reply to comment #20)
> > MUST:
> > X rpmlint on eclipse-changelog srpm gives this as output
> > 
> > W: eclipse-changelog non-standard-group Text Editors/Integrated Development
> > Environments (IDE)
> > 
> > Let's change this to Development/Tools as per:
> > 
> > https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204525#c5
> 
> Done.

You've got "Development/Toos" :)

> > X license text included in package and marked with %doc
> > 
> > you'll need to include a copy of epl-v10.html and mark it with %doc in the
> > %files section
> 
> Done.

Almost:

RPM build errors:
    File not found by glob:
/var/tmp/eclipse-changelog-2.3.3-3-root-overholt/usr/share/eclipse/features/com.redhat.eclipse.changelog_*/epl-v10.html

You need to actually include the file.  I'd say put it in ChangeLog CVS (in
features/com.redhat.eclipse.changelog) and roll a new tarball.  Call it 2.3.3.1
or something.

> > X package does not include license text
> 
> Done.
> 
> > X package builds in mock
> >   my mock setup doesn't seem to be working but I don't anticipate any problems
> >   here as the package currently builds fine in brew
> 
> Nothing to do.
> 
> 
> New versions uploaded to 
> 
> Spec URL: http://sourceware.org/eclipse/changelog/eclipse-changelog.spec
> SRPM URL:
> http://sourceware.org/eclipse/changelog/eclipse-changelog-2.3.3-3.fc7.src.rpm
> 



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the Fedora-package-review mailing list