[Bug 198816] Review Request: gfs-utils - global file system userland utilities

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gfs-utils - global file system userland utilities


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198816


ruben at rubenkerkhof.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|bugzilla-sink at leemhuis.info |ruben at rubenkerkhof.com
OtherBugsDependingO|163776, 177841              |163778
              nThis|                            |




------- Additional Comments From ruben at rubenkerkhof.com  2007-01-22 18:11 EST -------
Hi Chris,

Since you've been sponsored by jkatz, I'll remove the FE-NEEDSPONSOR blocker.

I've found a few things though:

rpmlint of gfs-utils is not silent:
W: gfs-utils incoherent-version-in-changelog 0.1.0-0.fc6.0 0.1.0-0.fc6.2
W: gfs-utils service-default-enabled /etc/rc.d/init.d/gfs
E: gfs-utils missing-mandatory-lsb-tag Description
E: gfs-utils missing-mandatory-lsb-tag Short-Description
W: gfs-utils incoherent-init-script-name gfs

The package should contain the text of the license
  (wiki: Packaging/ReviewGuidelines)

Scriptlets: missing "service" in %preun (wiki: ScriptletSnippets)
Scriptlets: missing "service" in %postun (wiki: ScriptletSnippets)

* Missing SMP flags. If it doesn't build with it, please add a comment
  (wiki: PackagingGuidelines#parallelmake)
* No downloadable source. Please give the full URL in the Source tag.

Please don't hardcode the distro in Release, use %dist

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.