[Bug 221045] Review Request: gtk-rezlooks-engine - Rezlooks GTK2 engine

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gtk-rezlooks-engine - Rezlooks GTK2 engine


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221045


mtasaka at ioa.s.u-tokyo.ac.jp changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |mtasaka at ioa.s.u-tokyo.ac.jp
OtherBugsDependingO|163776                      |163778
              nThis|                            |




------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2007-01-24 13:06 EST -------
Well,
* Firstly, Fedora's packaging policy by default is "all or
  nothing" unless there is a certain reason for conditional
  dependency (check: "Conditional dependencies" in
  http://fedoraproject.org/wiki/Packaging/Guidelines )

  What I mean by here is: I browsed under
  http://people.os-zen.net/rezza/themes/ , there are 6 themes
  named "Rezlooks-XXX.tar.gz", while you seem to have chosen
  4 of them and 2 erased by the some reason.

  If you have a reason why you didn't include 2 themes, please
  comment in the spec file why (sorry if it was only because there
  was only 4 themes when you packaged this srpm). Otherwise, 
  you must include "all" themes or include "nothing".

  Then..
  * rpmlint for srpm:
------------------------------------------------------
W: gtk-rezlooks-engine strange-permission Rezlooks-Snow.tar.gz 0600
W: gtk-rezlooks-engine strange-permission Rezlooks-Gilouche.tar.gz 0600
W: gtk-rezlooks-engine strange-permission gtk-rezlooks-engine.spec 0600
W: gtk-rezlooks-engine strange-permission Rezlooks-graphite.tar.gz 0600
W: gtk-rezlooks-engine strange-permission Rezlooks-candy.tar.gz 0600
W: gtk-rezlooks-engine strange-permission 39179-rezlooks-0.6.tar.gz 0600
------------------------------------------------------
   Please change the permission of files included in srpm
   to 0644.

   * Documentation
     /usr/share/doc/gtk-rezlooks-engine-0.6/NEWS says:
------------------------------------------------------
See Changelog for news.
-------------------------------------------------------
     This file is useless and please include Changelog instead.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.