[Bug 224413] Review Request: php-pear-Console-Color - Easily use ANSI console colors from PHP applications

bugzilla at redhat.com bugzilla at redhat.com
Thu Jan 25 17:09:06 UTC 2007


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-Console-Color - Easily use ANSI console colors from PHP applications
Alias: pear-Console-Color

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=224413





------- Additional Comments From chris.stone at gmail.com  2007-01-25 12:08 EST -------
==== REVIEW CHECKLIST ====
- rpmlint output clean
- package named according to package naming guidelines
- spec file name matches %{name}
- package meets packaging guidelines
- licensed with open source compatible license
- license field matches actual license
- source package does not include license text
- spec written in American english
- spec file is legible
- sources match upstream
0ed565fb5b3f3ed2d604053d9e1adce6  Console_Color-1.0.1.tgz
- package successfully compiles and builds on FC-6 x86_64
- all build dependencies listed in BR
- no locales
- no shared libraries
- package is not relocatable
X package does not own all directories it creates
- directories it does not create are pulled in from other packages
- no duplicates in %files
- file permissions set properly
- contains proper %clean section
- macro usage consistent
- contains code
- no large documentation
- %doc does not affect runtime
- no header files or static libraries
- no pkgconfig files
- no library files with suffixes
- no need for devel subpackage
- no libtool archives
- not a GUI app
- package does not own files or directories owned by other non-pear packages


==== MUST FIX ====
- This package must own the Console directory

==== SHOULD FIX ====
- Consider adding a PHP License text file to %doc


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the Fedora-package-review mailing list