[Bug 215445] Review Request: netcdf-decoder Converts WMO GRIB products into NetCDF files

bugzilla at redhat.com bugzilla at redhat.com
Thu Jan 25 19:28:01 UTC 2007


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: netcdf-decoder Converts WMO GRIB products into NetCDF files


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=215445





------- Additional Comments From Jochen at herr-schmitt.de  2007-01-25 14:28 EST -------
I will cite:

Why the %makeinstall macro should not be used

Fedora's RPM includes a %makeinstall macro but it must NOT be used when make
install DESTDIR=%{buildroot} will work. %makeinstall is a kludge that can work
with Makefiles that don't make use of the DESTDIR variable but it has the
following potential issues:

    *

      %makeinstall overrides a set of environment variables during "make
install". I.e. it performs make prefix="..." includedir="..." ...
    *

      It is error prone, and can have unexpected effects when run against less
than perfect Makefiles.
    *

      It can trigger unnecessary rebuilds when executing "make install"
    *

      If a package contains libtool archives, it can cause broken *.la files to
be installed.

Instead, Fedora packages should use: make DESTDIR=%{buildroot} install or make
DESTDIR=$RPM_BUILD_ROOT install

Thsi is a list of reasons why %Makeinstall should not used.

Sory for any inconviniences.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the Fedora-package-review mailing list