[Bug 222552] Review Request: mailgraph - A RRDtool frontend for Mail statistics

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: mailgraph - A RRDtool frontend for Mail statistics


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222552


ruben at rubenkerkhof.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|ruben at rubenkerkhof.com      |nobody at fedoraproject.org
                 CC|                            |ruben at rubenkerkhof.com
OtherBugsDependingO|163778                      |163776, 177841
              nThis|                            |




------- Additional Comments From ruben at rubenkerkhof.com  2007-01-27 18:09 EST -------
Must:

- package conforms to package naming guidlines
- spec file name matches basename
- the package is licensed with an open source compatible license
- package includes license in %doc
- spec file is written in american english
- spec file is legible
- sources match upstream (sha1sum):
   08bbe7f6e66f1b14b40ce7da8caa716b6ee122e3  mailgraph-1.12.tar.gz
- package successfully built on my test box (i386)
- no need for exclude arch (noarch package)
- files in %doc does not affect runtime of application
- does not contain a pkgconfig file
- does not contain any libraries
- does not have a devel package
- does not contain any .la files
- package does not have a gui
- package does not own files/directories owned by other packages.
- no libraries, no need to run ldconfig
- not relocatable
- package owns everything it creates
- package does not duplicate files it owns
- consistently uses macros
- code, not content

Needs work:

- rpmlint errors:
   E: mailgraph non-standard-gid /var/cache/mailgraph apache.
   This can be ignored, but you should Require httpd, otherwise you can't be sure
   this user exists.
   E: mailgraph non-standard-dir-perm /var/cache/mailgraph 0775.
   Can't you make apache the owner of the directory?

- Do you need the repotag in Release?
- Please preserve timestamps when installing files (Packaging/Guidelines/Timestamps)

I see you have not been sponsored yet, and I'm not a sponsor, so I'll have to put the FE-NEEDSPONSOR 
blocker back.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.