[Bug 216723] Review Request: libsieve - A library for parsing, sorting and filtering your mail

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libsieve - A library for parsing, sorting and filtering your mail


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=216723





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2007-01-29 02:33 EST -------
(In reply to comment #15)
> Created an attachment (id=146783)
 --> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=146783&action=view) [edit]
> possible patch for cflags
> 
> Would this patch be considered acceptable or do I need to fix autotools and
> regenerate everything?

Well, we recommend _not_ to use autotool. Your patch is
good, however, when I checked your patch, the following may
be simpler.
----------------------------------------------------------
%prep 
%setup -q

%{__sed} -i.cflags \
	 -e 's|^\(CFLAGS = -Wall\)|\1 @CFLAGS@|' \
	 `find . -name Makefile -or -name Makefile.in`
----------------------------------------------------------

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.