[Bug 222521] Review Request: IceWM - Lightweight Window Manager.

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: IceWM -  Lightweight Window Manager.


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222521





------- Additional Comments From pertusus at free.fr  2007-01-29 08:32 EST -------
Your argument about having separate xdgmenu subpackage seems
relevant to me.

[ -f ~/.Xdefaults ] && xrdb -load ~/.Xdefaults
should be handled by the session opening. This doesn't belong
here. I showed above that this should be handled in xinit and
gdm, if it isn't then you should fill a bug against the relevant
package, not try to workaround it.

Also I think it would be better to have the startup file in 
the main package, but it wouldn't do anything interesting 
if icewm-xdg-menu isn't installed. It could be generated at
%install time, like

cat > %{buildroot}%{_datadir}/icewm/startup <<EOF
[ ! -d ~/.icewm ] && mkdir ~/.icewm
if [ -x %{_bindir}/icewm-xdg-menu ]; then
  %{_bindir}/icewm-xdg-menu --entire-menu --with-theme-paths --icon-size 16
--theme Bluecurve > ~/.icewm/programs.autogen
fi
EOF

chmod 0755 %{buildroot}%{_datadir}/icewm/startup


Also you should use consistently %{buildroot} or $RPM_BUILD_ROOT.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.