[Bug 225119] Review Request: pythoncad - PythonCAD scriptable CAD package

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: pythoncad - PythonCAD scriptable CAD package


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225119





------- Additional Comments From ynakam at hitachisoft.jp  2007-01-30 00:41 EST -------
I am not sponsor, so it is pre-review.
I am also seeking for sponsor, at Bug 222594 .
I have looked at your spec file, and have some comments.

1) Block FE-NEEDSPONSOR
Please input "FE-NEEDSPONSOR" at Bug 225119 blocks ...
By this, possible sponsor might find you :-)

2) cp pythoncad.desktop $RPM_BUILD_ROOT%{_datadir}/applications/

You have to use desktop-file-install command.
http://fedoraproject.org/wiki/Packaging/Guidelines#head-254ddf07aae20a23ced8cecc219d8f73926e9755

3) File copy
You are using cp and chmod command to install files,
but you can do it by "install -m <permission>".
And, please do not forget to use "-p" option:
http://fedoraproject.org/wiki/Packaging/Guidelines#head-0239576e441f9ef53d175c4aec8c12868dffb5ab

4) BuildRequires
You are using "setup.py", but it requires "python-tools" package.

And you can omit "python":
http://fedoraproject.org/wiki/Extras/FullExceptionList

5) [ "$RPM_BUILD_ROOT" != "/" ] && rm -rf "$RPM_BUILD_ROOT"
It is not commonly used.
rm -rf "$RPM_BUILD_ROOT" will work.

6) Spec file name
%{name} in your package is "PythonCAD", however, spec name is "pythoncad.spec".
I think you have to use either "PythonCAD" or "pythoncad".
please look at below:
http://fedoraproject.org/wiki/Packaging/NamingGuidelines#head-625ebbc8678382beca8d0b02504d30e7b6f23791

7) *.pyo *.pyc in /usr/bin/
>From rpmlint:
W: PythonCAD non-executable-in-bin /usr/bin/gtkpycad.pyo 0644
W: PythonCAD non-executable-in-bin /usr/bin/gtkpycad.pyc 0644
If you change executable name from "gtkpycad.py" to "gtkpycad", it will not
appear, and I think it is better.

8)
http://kwizart.free.fr/fedora/SPECS/pythoncad.spec
and spec file included in SRPM is different one.

9) python setup.py install --prefix=/usr --root=$RPM_BUILD_ROOT
You can use %{__python} .

10) Should I changes these perm to 755 ?
I think so..

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.