[Bug 225126] Review Request: dxpc - A Differential X Protocol Compressor

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: dxpc - A Differential X Protocol Compressor


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225126





------- Additional Comments From bugs.michael at gmx.net  2007-01-31 05:16 EST -------
That could be due to a rewrite of the EncodeBuffer/DecodeBuffer code
in 3.9.0. Interestingly, the Debian folk offers this dxpc for AMD64
for several months without any patch in that area of the code:
http://packages.debian.org/unstable/x11/dxpc

In the source I see a 32-bit bit-shifting en-/decoding working with
"unsigned int" most of the time in many places, but sometimes only
with simple type-specifiers. Maybe there's an oversight somewhere.
Without an x86_64 test machine I won't even start careful proof-reading,
however. Also, the upstream authors are encouraged to use full
type-specifiers wherever possible, e.g. "unsigned int X" instead
of "unsigned X" and "sizeof(unsigned int)" instead "sizeof(unsigned)".

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.