[Bug 247704] Review Request: gifsicle - Powerful program for manipulating GIF images and animations

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gifsicle - Powerful program for manipulating GIF images and animations


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=247704


pertusus at free.fr changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |pertusus at free.fr
               Flag|                            |fedora-review+




------- Additional Comments From pertusus at free.fr  2007-07-10 16:50 EST -------
* rpmlint is silent
* free software, license included. 
CLP is BSD-like, the remaining is GPL. Some portability files 
don't have copyright holder, are simple and may be considered
public domain, in my opinion.
* follow packaging guidelines
* match upstream
3857d3d920180f2b9bac32c7b1a2e276  gifsicle-1.48.tar.gz
* Sane Provides
* %files section right
* build and work fine on devel

You should keep the timestamp of the source tarball, for example
with wget -N or spectool -g.

$ ls -l gifsicle-1.48.tar.gz ../SOURCES/gifsicle-1.48.tar.gz 
-rw-rw-r-- 1 dumas dumas 248110 mar 17 00:00 gifsicle-1.48.tar.gz
-rw-r--r-- 1 dumas dumas 248110 jui 10 21:35 ../SOURCES/gifsicle-1.48.tar.gz

This is not a blocker.

You could consider putting gifview in a separate package if
you want to avoid the dependency on X libraries, but I think
this should be left to you.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.