[Bug 241279] Review Request: avr-libc - C library for use with GCC on Atmel AVR microcontrollers

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: avr-libc - C library for use with GCC on Atmel AVR microcontrollers


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=241279





------- Additional Comments From j.w.r.degoede at hhs.nl  2007-07-13 17:28 EST -------
(In reply to comment #9)
> http://fedoraproject.org/wiki/Packaging/ReviewGuidelines
> 
> Here are all the MUST items that have problems
> 
> - MUST: The License field in the package spec file must match the actual license.
>    --> NOT OK: project: modified BSD, package spec: GPL
> 

Oops, good catch, will fix

> - MUST: Header files must be in a -devel package.
>    --> hmm... discuss? (see rpmlint output)
> 
> - MUST: Static libraries must be in a -static package.
>    --> hmm... discuss? (see rpmlint output)
> 
> Possible solution: split out -devel package and have avr-libc require:
> avr-libc-devel? Or possibly just rename the package.
> 

As already explained in the mailinglist discussion, the guidelines or just plain
bogus in this (exceptional) case, just ignore them.

> - MUST: Packages must not own files or directories already owned by other
packages.
>    --> BAD
> $ rpm -qf /usr/avr
> avr-binutils- 2.17-3.fc7.x86_64
> avr-libc- 1.4.6-1.x86_64
> 

Unfortunately the review checklist is a bit to short / simple when describing
this. see:
http://fedoraproject.org/wiki/Packaging/Guidelines#head-a5931a7372c4a00065713430984fa5875513e6d4

For the full story, to quote it: "Another exception for directory ownership in
packages is when there is no clear dependency hierarchy.

An example:

Foo-Animal-Emu puts files into /usr/share/Foo/Animal/Emu
Foo-Animal-Llama puts files into /usr/share/Foo/Animal/Llama

Neither package depends on the other one. Neither package depends on any other
package which owns the /usr/share/Foo/Animal/ directory. In this case, each
package must own the /usr/share/Foo/Animal/ directory."

Since binutils doesn't need libc and libc doesn't need binutils there is no
clear dependency hierarchy, thus they should both own /usr/avr

Ah, I just saw your comment you find this ourselves, yes its no an issue.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.