[Bug 248231] Review Request: ustr - String library, very low memory overhead, simple to import

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ustr - String library, very low memory overhead, simple to import


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=248231





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2007-07-27 12:41 EST -------
Created an attachment (id=160126)
 --> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=160126&action=view)
mock build log of ustr 1.0.1-0 on rawhide i386 (2nd time)

(Assuming that you are the upstream of this package
 and you have not yet released 1.0.1 formally)

* For /sbin/ldconfig, usually we don't write Requires(post) and
  so on.

* rpm (sub)packages which contains pkgconfig .pc files should
  have "Requires: pkgconfig"

* mock build log says that fedora specific compilation flags are
  not honored.

* The following directories are not owned by any packages.
------------------------------------------------------
%{_datadir}/ustr-%{version}/
%{_datadir}/doc/ustr-devel-%{version}/
------------------------------------------------------
* Usually the dependency for other subpackages must be
  version-release specific. i.e. -devel package should have
  Requires: %{name} = %{version}-%{release}, for example

* Use %_includedir for /usr/include.

* I have not installed ustr yet, however would you check the
  dependencies between subpackages?
  For example, why does -debug subpackage require -static subpackage?
  (well, this is a question)

* For summary
(In reply to comment #2)
> * summary seems all the same for all packages??
>  This is common for libraries, no? For instance glib2 and glib2-devel 
> have the same summary but different descriptions ... 
  Strange... Anyway as you can try "rpmdev-newspec libfoo" to
  create skeleton spec file, usually summary and description for
  -devel subpackage are like:
--------------------------------------------------------
%package	devel
Summary:	Development files for %{name}
Group:		Development/Libraries
Requires:	%{name} = %{version}-%{release}

%description	devel
The %{name}-devel package contains libraries and header files for
developing applications that use %{name}.
----------------------------------------------------------

* And please increase release number
  (Perhaps you want to set release number as 1 when review is done

   and wants to set release number 0 during review, but please
   don't. At least please increase release number as 0.1, 0.2, ...)

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.