[Bug 241978] Review Request: tig - Text-mode interface for git

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: tig - Text-mode interface for git


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=241978





------- Additional Comments From tibbs at math.uh.edu  2007-06-01 01:00 EST -------
Looks good.  I do think a quick chmod of the manpages is in order just for the
sake of cleanliness, although I can't imagine how the weird permissions could
actually hurt anything.

The compiler is not called with the proper set of flags, which leads to a busted
debuginfo package among other things.  I believe it suffices to pass CFLAGS on
the make line:
   make CFLAGS='%{optflags}' %{?_smp_mflags} all doc-man

The only other suggestion I have is that while don't think there's anything
wrong with the summary and description you have, perhaps not everyone who sees
the summary or description will know what git is.  Maybe something like:

Summary: Text-mode interface for the git revision control system
%description
Tig is a repository browser for the git revision control system that...

Review:
* source files match upstream:
   ad611a9449ff9786892183874ee79255ab92e82b3d1251556cd1a0cd1224ee12  
   tig-0.7.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
O summary is OK (see comments above, not a blocker)
O description is OK ("")
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text included in package.
* latest version is being packaged.
* BuildRequires are proper.
X compiler flags are appropriate.
* %clean is present.
* package builds in mock (development, x86_64).
* package installs properly
X debuginfo package is mostly empty.
* rpmlint is silent.
* final provides and requires are sane:
   tig = 0.7-1.fc7
  =
   git-core
   libncurses.so.5()(64bit)
   libtinfo.so.5()(64bit)
* %check is not present (no upstream test suite) but package runs fine.
* no shared libraries are added to the regular linker search paths.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
X file permissions are appropriate (executable manpages)
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no static libraries.
* no libtool .la files.
* not a GUI app.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.