[Bug 241978] Review Request: tig - Text-mode interface for git

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: tig - Text-mode interface for git


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=241978





------- Additional Comments From jbowes at redhat.com  2007-06-01 07:15 EST -------
(In reply to comment #2)
> Looks good.  I do think a quick chmod of the manpages is in order just for the
> sake of cleanliness, although I can't imagine how the weird permissions could
> actually hurt anything.
> 
> The compiler is not called with the proper set of flags, which leads to a busted
> debuginfo package among other things.  I believe it suffices to pass CFLAGS on
> the make line:
>    make CFLAGS='%{optflags}' %{?_smp_mflags} all doc-man
> 
> The only other suggestion I have is that while don't think there's anything
> wrong with the summary and description you have, perhaps not everyone who sees
> the summary or description will know what git is.  Maybe something like:
> 
> Summary: Text-mode interface for the git revision control system
> %description
> Tig is a repository browser for the git revision control system that...

This all sounds good. I've updated the spec with your suggestions. Thanks, Jason.

New locations:
Spec URL: http://jbowes.dangerouslyinc.com/tmp/tig.spec
SRPM URL: http://jbowes.dangerouslyinc.com/tmp/tig-0.7-2.fc7.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.