[Bug 241553] Review Request: safekeep - simple, centralized configuration for rdiff-backup

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: safekeep -  simple, centralized configuration for rdiff-backup


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=241553





------- Additional Comments From sebastien.prudhomme at gmail.com  2007-06-02 18:11 EST -------
+ simple build
+ mock build

- rpmlint safekeep-server-1.0.0-2.noarch.rpm (correct at least the
conffile-without-noreplace-flag warning)

W: safekeep-server spurious-executable-perm
/usr/share/doc/safekeep-server-1.0.0/safekeep-test
E: safekeep-server non-standard-uid /var/lib/safekeep safekeep
E: safekeep-server non-standard-gid /var/lib/safekeep safekeep
E: safekeep-server non-standard-dir-perm /var/lib/safekeep 0750
E: safekeep-server non-standard-uid /var/lib/safekeep/.ssh safekeep
E: safekeep-server non-standard-gid /var/lib/safekeep/.ssh safekeep
W: safekeep-server hidden-file-or-dir /var/lib/safekeep/.ssh
E: safekeep-server non-standard-dir-perm /var/lib/safekeep/.ssh 0700
W: safekeep-server hidden-file-or-dir /var/lib/safekeep/.ssh
W: safekeep-server conffile-without-noreplace-flag /etc/safekeep/safekeep.conf
W: safekeep-server doc-file-dependency
/usr/share/doc/safekeep-server-1.0.0/safekeep-test /usr/bin/python
W: safekeep-server dangerous-command-in-%post mv
W: safekeep-server dangerous-command-in-%preun userdel

- openssh requirement seems not necessary (is yet required by openssh-clients)
- gecos field for the safekeep user ("Useful comment about the purpose of this
account")
- as this seems to be the a new package for Fedora, i don't understand the
migration of conf files from /etc/safekeep.d to /etc/safekeep/backup.d
- man pages for safekeep.backup and safekeep.conf should be in the
safekeep-server rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.