[Bug 241624] Review Request: perl-GD-Barcode - Create barcode image with GD

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-GD-Barcode - Create barcode image with GD


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=241624


tibbs at math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From tibbs at math.uh.edu  2007-06-03 17:46 EST -------
Are you really sure there's any point in packaging test.pl?
   BEGIN { $| = 1; print "1..1\n"; }
   END {print "not ok 1\n" unless $loaded;}
   use GD::Barcode;
   $loaded = 1;
   print "ok 1\n";
It doesn't seem to me to be especially useful as documentation.

Other than that, there's not much to say.

Review:
* source files match upstream:
   8c22b449079dce65946ec72acf6d3db78753045e7738c5101bc26932c9704967  
   GD-Barcode-1.15.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text not included upstream.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (development, x86_64).
* package installs properly
* rpmlint is silent.
* final provides and requires are sane:
   perl(GD::Barcode)
   perl(GD::Barcode::COOP2of5)
   perl(GD::Barcode::Code39)
   perl(GD::Barcode::EAN13)
   perl(GD::Barcode::EAN8)
   perl(GD::Barcode::IATA2of5)
   perl(GD::Barcode::ITF)
   perl(GD::Barcode::Industrial2of5)
   perl(GD::Barcode::Matrix2of5)
   perl(GD::Barcode::NW7)
   perl(GD::Barcode::QRcode)
   perl(GD::Barcode::UPCA)
   perl(GD::Barcode::UPCE)
   perl-GD-Barcode = 1.15-1.fc7
  =
   perl(:MODULE_COMPAT_5.8.8)
   perl(Exporter)
   perl(GD)
   perl(GD::Barcode)
   perl(constant)
   perl(strict)
   perl(vars)

* %check is present and the single test passes.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.