[Bug 241792] Review Request: Empathy - An instant messaging client built using Telepathy

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Empathy - An instant messaging client built using Telepathy
Alias: empathy

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=241792


bdpepple at ameritech.net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-review+




------- Additional Comments From bdpepple at ameritech.net  2007-06-04 16:14 EST -------
MD5Sums:
d8b51a02718f4e28a9916d54f3a9a3c0  empathy-0.6.tar.bz2

Good:
* Source URL is canonical
* Upstream source tarball verified
* Package name conforms to the Fedora Naming Guidelines
* Group Tag is from the official list
* Buildroot has all required elements
* All paths begin with macros
* All directories are owned by this or other packages (except item in Bad section)
* All necessary BuildRequires listed.
* All desired features are enabled
* Make succeeds even when %{_smp_mflags} is defined
* Builds fine in mock.
* rpmlint produces only the following warning, which can be safely ignored:
 W: empathy non-conffile-in-etc /etc/gconf/schemas/empathy.schemas

Bad:
 * missing Requires on telepathy-filesystem.  this makes sure
%{_datadir}/telepathy/managers is correctly owned.

Strongly Urge Changing:
 * There is no guideline that I'm aware of that states you can't use the
autostart directory.  IMHO though this is a REALLY poor idea to do on this package.

Ok, now that I've got that out of the way.

+1 APPROVE, provided that you add the telepathy-filesytem as a requires before
importing into cvs.  Also, as I mentioned earlier I'm willing to be your sponsor.

http://fedoraproject.org/wiki/PackageMaintainers/Join#head-a601c13b0950a89568deafa65f505b4b58ee869b

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.