[Bug 242545] Review Request: ftplib - Library of FTP routines

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ftplib - Library of FTP routines


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=242545


dan at danny.cz changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |NEEDINFO
               Flag|fedora-review?              |needinfo?(tcallawa at redhat.co
                   |                            |m), fedora-review-




------- Additional Comments From dan at danny.cz  2007-06-04 16:18 EST -------
OK	source files match upstream:
	e7f6b8faab22042595a94c80a784c92da6431951b0ae4aa039b83d6790cab147 
ftplib-3.1-1.tar.gz

OK	package meets naming and versioning guidelines.
OK	specfile is properly named, is cleanly written and uses macros consistently.
OK	dist tag is present.
OK	build root is correct.
BAD	license field doesn't matches the actual license.
		the library is LGPL, the client is GPL

OK	license is open source-compatible. License text not included upstream.
OK	latest version is being packaged.
OK	BuildRequires are proper.
OK	compiler flags are appropriate.
OK	%clean is present.

OK	debuginfo package looks complete.
OK	rpmlint is silent.
OK	final provides and requires look sane
OK	shared libraries are added to the regular linker search paths, ldconfig is run
OK	doesn't create new directories
OK	doesn't own any directories it shouldn't.
OK	no duplicates in %files.
OK	file permissions are appropriate.
OK	correct scriptlets are present.
OK	code, not content.
OK	documentation is small, so no -docs subpackage is necessary.
OK	%docs are not necessary for the proper functioning of the package.
OK	headers and devel libs are in devel subpackage
OK	no pkgconfig files.
OK	no libtool .la
OK	not a GUI app.

??	package builds in mock (x86_64) - still downloading packages ;-)

Everything looks good, only the licences should be corrected - see the attached
patch.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.