[Bug 242311] Review Request: perl-Time-Duration - rounded or exact English expression of durations

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Time-Duration - rounded or exact English expression of durations


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=242311


cweyl at alumni.drew.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cweyl at alumni.drew.edu




------- Additional Comments From cweyl at alumni.drew.edu  2007-06-04 19:06 EST -------
Heya -- a couple initial comments, not a review.

Overall the spec looks fairly clean, especially for a first submission :)  There
are some tweaks that could be made -- and some perl-specific bits.  Note you can
find the (draft!) perl packaging best practices at:  

    http://fedoraproject.org/wiki/PackagingDrafts/Perl

For perl buildrequires, it's preferable to specify the module needed rather than
the package containing the module (e.g. perl(Test::Pod) rather than perl-Test-Pod).

There's a perl-split which may be coming down the pike.  It's recommended to
buildrequire Test::More or ExtUtils::MakeMaker if either are required (and it
looks like the latter is).

As it's a noarch package, this line can be nixed safely:

    find %{buildroot} -type f -name '*.bs' -size 0 -exec rm -f {} \;

"chmod -R u+rwX,go+rX,go-w" works, but %{_fixperms} is so much easier on the eyes :)

%doc in %files is (by convention) placed at the top of the files list.

%{?dist} is usually left out of the changelog version-release.

%{perl_vendorlib}/Time/Duration.pm is redundant; the first line will include
%{perl_vendorlib}/Time and everything below it, as it's a directory:

   %{perl_vendorlib}/Time
   %{perl_vendorlib}/Time/Duration.pm

The spec is missing a %check section; I haven't checked Time-Duration itself but
if the distribution includes any tests it's important to run them.  e.g.

   %check
   make test


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.