[Bug 218599] Review Request: klibido - NNTP (Usenet) file grabber for KDE

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: klibido - NNTP (Usenet) file grabber for KDE


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=218599





------- Additional Comments From tibbs at math.uh.edu  2007-06-05 01:51 EST -------
Overall, this is a clean package.  rpmlint says only:
   W: klibido dangling-relative-symlink /usr/share/doc/HTML/en/klibido/common 
      ../common
This is normal for KDE packages; they depend on the base KDE package which will
provide the link target.

One primary issue is that this links statically against libuu.  Not that you
have much choice as it's only provided as a static library.  (That's unfortunate
as it's going to see untrusted content and has had a buffer overflow issue in
the past.)

So, to make this obvious, please make the build dependency on uulib-static
instead of uulib so that we can grep for it.  I'll raise the static linking
issue with FESCo.  (All instances of static linking must be explicitly approved.)

You use both $RPM_BUILD_ROOT and %{buildroot} at various points in the spec. 
You can use whichever you like, but you should be consistent.

The /usr/share/icons/hicolor/*/apps directories are unowned.  You should have a
runtime dependency on hicolor-icon-theme to bring them in.

The .desktop file has no GenericName entry; it uses Comment instead.  I also
believe that it's common KDE usage to capicalize the 'K' in the program name for
the menu.

Review:
* source files match upstream:
   7bd35c5cf6f1b9b26f802e78d63e9ae7a66763ca4c0c4a78ecc87d45a20b1d22  
   klibido-0.2.5.tar.gz
* package meets naming and versioning guidelines.
X specfile is properly named, is cleanly written but does not consistently use 
  $RPM_BUILD_ROOT/%{buildroot}.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text included in package.
* latest version is being packaged.
X BuildRequires are proper (please use uulib-static to make the static linking 
  obvious.)
* compiler flags are appropriate.
* %clean is present.
* package builds in mock (development, x86_64).
* package installs properly
* debuginfo package looks complete.
* rpmlint has only acceptable complaints.
X final provides and requires:
   klibido = 0.2.5-5.fc7
  =
   libDCOP.so.4()(64bit)
   libICE.so.6()(64bit)
   libSM.so.6()(64bit)
   libX11.so.6()(64bit)
   libXext.so.6()(64bit)
   libXrender.so.1()(64bit)
   libdb-4.5.so()(64bit)
   libdb_cxx-4.5.so()(64bit)
   libgcc_s.so.1()(64bit)
   libgcc_s.so.1(GCC_3.0)(64bit)
   libkdecore.so.4()(64bit)
   libkdefx.so.4()(64bit)
   libkdesu.so.4()(64bit)
   libkdeui.so.4()(64bit)
   libkio.so.4()(64bit)
   libkmdi.so.1()(64bit)
   libkparts.so.2()(64bit)
   libkutils.so.1()(64bit)
   libkwalletclient.so.1()(64bit)
   libpthread.so.0()(64bit)
   libpthread.so.0(GLIBC_2.2.5)(64bit)
   libqt-mt.so.3()(64bit)
   libstdc++.so.6()(64bit)
   libstdc++.so.6(CXXABI_1.3)(64bit)
   libstdc++.so.6(GLIBCXX_3.4)(64bit)
   libutempter.so.0()(64bit)
   libutil.so.1()(64bit)
   libz.so.1()(64bit)
 X Missing hicolor-icon-theme dependency.
* %check is not present; no test suite upstream.  I installed it on my desktop 
   and it seemed to work well enough.
* no shared libraries are added to the regular linker search paths.
X owns the directories it creates (/usr/share/icons/hicolor/*)
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no static libraries.
* no libtool .la files.
X Desktop file has minor issues.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.